Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "bpo-43510: PEP 597: Accept encoding="locale" in binary mode." #25108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Revert "bpo-43510: PEP 597: Accept encoding="locale" in binary mode." #25108

merged 1 commit into from
Mar 31, 2021

Conversation

methane
Copy link
Member

@methane methane commented Mar 31, 2021 •
edited by bedevere-bot
Loading

vstinner
vstinner approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, it sounds really weird to accept an encoding when a file is opened in binary mode. open(filename, "rb", encoding="locale") looks like a bug.

@methane methane merged commit cfa1766 into master Mar 31, 2021
@methane methane deleted the revert-25103-binary-locale branch March 31, 2021 09:49
@bedevere-bot
Copy link

@methane: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @bedevere-bot @vstinner @the-knights-who-say-ni