Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. #25595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orsenthil merged 10 commits into from
Apr 29, 2021
Merged

bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. #25595

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
60c9b55
issue43882 - urllib.parse should sanitize urls containing ASCII newli…
orsenthil Apr 25, 2021
ee779d6
Address Code Review Comments.
orsenthil Apr 28, 2021
e81f32f
Give link to specification. Reference in WG page in Seealso links.
orsenthil Apr 28, 2021
ae07b8f
Wording cleanup and ReST editing for NEWS.
gpshead Apr 29, 2021
908e744
Update Doc/library/urllib.parse.rst
orsenthil Apr 29, 2021
5f61b9e
Update Misc/NEWS.d/next/Security/2021-04-25-07-46-37.bpo-43882.Jpwx85…
orsenthil Apr 29, 2021
4afcf42
Update Doc/library/urllib.parse.rst
orsenthil Apr 29, 2021
0885aff
Merge branch 'master' into issue43882
orsenthil Apr 29, 2021
1150995
Merge branch 'issue43882' of github.com:orsenthil/cpython into issue4…
orsenthil Apr 29, 2021
025718e
Merge branch 'master' into issue43882
orsenthil Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/library/urllib.parse.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ or on combining URL components into a URL string.
decomposed before parsing, no error will be raised.

Following the `WHATWG spec`_ that updates RFC 3986, ASCII newline
``\n``, ``\r`` and tab ``\t`` characters are stripped from the url.
``\n``, ``\r`` and tab ``\t`` characters are stripped from the URL.

.. versionchanged:: 3.6
Out-of-range port numbers now raise :exc:`ValueError`, instead of
Expand All @@ -324,7 +324,7 @@ or on combining URL components into a URL string.
now raise :exc:`ValueError`.

.. versionchanged:: 3.10
ASCII newline and tab characters are stripped from the url.
ASCII newline and tab characters are stripped from the URL.

.. _WHATWG spec: https://url.spec.whatwg.org/#concept-basic-url-parser

Expand Down
8 changes: 4 additions & 4 deletions Misc/NEWS.d/next/Security/2021-04-25-07-46-37.bpo-43882.Jpwx85.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Presence newline or tab characters in URL allowed attackers to write scripts
in URL, hijack the the the web-server.
The presence of newline or tab characters in parts of a URL could allow
some forms of attacks.

Following the controlling specification for URLs defined by WHATWG
urllib.parse strips ASCII newline and tabs from the url, preventing such
attacks.
:func:`urllib.parse` now removes ASCII newlines and tabs from URLs,
preventing such attacks.