Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-42064: Remove stale extern declarations in sqlite3 headers #26840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2021
Merged

bpo-42064: Remove stale extern declarations in sqlite3 headers #26840

merged 3 commits into from
Jun 23, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 21, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from pablogsal June 21, 2021 22:34
@erlend-aasland erlend-aasland changed the title bpo-42064: Remove stale extern declarations in sqlite3 bpo-42064: Remove stale extern declarations in sqlite3 headers Jun 21, 2021
corona10
corona10 reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we may need to update Tools/c-analyzer/cpython/ignored.tsv

See:

cpython/Tools/c-analyzer/cpython/ignored.tsv

Line 58 in bb3e0c2

Modules/_sqlite/connection.h - pysqlite_ConnectionType -

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021 •
edited
Loading

IMHO, we may need to update Tools/c-analyzer/cpython/ignored.tsv

I didn't know about this; thanks for the heads up! I'll update the PR. UPDATE: fixed in 285b341

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021

@corona10 I'll have an extra look at this later today; there's a lot more that can be removed from the c-analyzer ignore list.

@erlend-aasland erlend-aasland marked this pull request as draft June 23, 2021 06:37
@erlend-aasland erlend-aasland marked this pull request as ready for review June 23, 2021 11:51
@erlend-aasland erlend-aasland requested a review from corona10 June 23, 2021 11:51
corona10
corona10 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 019ad62 into python:main Jun 23, 2021
@erlend-aasland erlend-aasland deleted the sqlite-cleanup branch June 23, 2021 12:09
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021

Thanks, @corona10 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @corona10 @the-knights-who-say-ni @bedevere-bot