[3.5] bpo-28556: Update to typing: treat subscripted generics as proxies (#265) #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit abb3b8a)
louisom
reviewed
Feb 24, 2017
Lib/typing.py
Outdated
| def __setattr__(self, attr, value): | ||
| # We consider all the subscripted genrics as proxies for original class | ||
| if attr.startswith('__') and attr.endswith('__'): | ||
| super(GenericMeta, self).__setattr__(attr, value) |
There was a problem hiding this comment.
I have a small question, why not just using super().__setattr__(attr, value) but super(GenericMeta, self)? Isn't that equivalent at this case?
There was a problem hiding this comment.
In principle you are right. This is mostly for similarity with next case (also there is Python 2 backport of this module, so that sometimes I just write the same code for both)
…thonGH-270) (cherry picked from commit 365cb5b)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 13, 2021
A failure to unpickle a frame could cause a NULL pointer access when deallocating the frame. This has been fixed.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit abb3b8a)
(cherry picked from commit 365cb5b)