bpo-26184: import.rst: Add versionchanged note #277
Conversation
an ImportError is raised when exec_module() is defined, but create_module() is not.
There was a problem hiding this comment.
Hi @Mariatta , it LGTM, but I would like you to add just a minor change, not directly related with this PR. In the first versionadded of the Loaders section, we do not have any markup for create_module():
.. versionadded:: 3.4
The create_module() method of loaders.
It should be:
.. versionadded:: 3.4
The :meth:`~importlib.abc.Loader.create_module` method of loaders.
Thank you very much
|
Thanks for the review, @Carreau and @marco-buttu . @marco-buttu, the change that you requested will require backport to 3.5 and 3.6 branches, whereas this PR will only be backported to 3.6. I will make that change as a separate PR from this. |
Mention that an ImportError is raised when exec_module() is defined, but create_module() is not. (cherry picked from commit 6b4a5f4)
|
|
||
| .. versionchanged:: 3.6 | ||
| An :exc:`ImportError` is raised when ``exec_module()`` is defined but | ||
| ``create_module`` is not. |
There was a problem hiding this comment.
I guess create_module should be create_module() here since the latter form is also used in the first versionchanged note.
There was a problem hiding this comment.
Thanks for catching this, @berkerpeksag! I fixed it in GH-325
Convert all files to Python3 and run/test them once.
Add versionchanged note indicating that an ImportError is raised when exec_module() is defined, but create_module() is not.
http://bugs.python.org/issue26184