doc: Remove backslashes in doctest grammar docs #29346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
CAM-Gerlach
approved these changes
Nov 26, 2022
There was a problem hiding this comment.
Yup, this change is correct. Per the Sphinx docs for productionlist:
Note that no further reST parsing is done in the production, so that you don’t have to escape * or | characters.
LGTM, thanks.
kumaraditya303
approved these changes
Nov 27, 2022
|
Thanks @GeeTransit for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-99809 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2022
(cherry picked from commit 22860db) Co-authored-by: George Zhang <[email protected]>
|
GH-99810 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2022
(cherry picked from commit 22860db) Co-authored-by: George Zhang <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 27, 2022
(cherry picked from commit 22860db) Co-authored-by: George Zhang <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 27, 2022
(cherry picked from commit 22860db) Co-authored-by: George Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backslashes in the grammar here have no effect and show up in the end result. I've done a quick search for
productionlistand no other doc page has backslashes (except where the backslash is shown, such as for string escapes). This pull request removes them.