Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-20392: Fix inconsistency with uppercase file extensions in mimetypes.guess_type #30229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2022
Merged

bpo-20392: Fix inconsistency with uppercase file extensions in mimetypes.guess_type #30229

merged 4 commits into from
Mar 15, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 22, 2021 •
edited by asvetlov
Loading

@kumaraditya303 kumaraditya303 requested a review from a team as a code owner December 22, 2021 12:00
sobolevn
sobolevn reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

From looking on the original patch, it looks like that you've missed this part:

-        The suffixes .tgz, .taz and .tz (case sensitive!) are all
+        The suffixes .tgz, .taz and .tz are all

Is it intentional?

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 23, 2021 •
edited
Loading

Thanks!

From looking on the original patch, it looks like that you've missed this part:

-        The suffixes .tgz, .taz and .tz (case sensitive!) are all
+        The suffixes .tgz, .taz and .tz are all

Is it intentional?

I haven't applied that patch and as you commented I even tried to apply it now but it is outdated so not worth copy pasting.

JelleZijlstra
JelleZijlstra reviewed Jan 20, 2022
View reviewed changes
@kumaraditya303 kumaraditya303 requested review from JelleZijlstra and removed request for a team March 10, 2022 09:25
JelleZijlstra
JelleZijlstra approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right but I'm not comfortable merging this; I'd like to hear from someone more familiar with MIME types first.

@asvetlov asvetlov changed the title bpo-20392: Fix inconsistency with uppercase file extensions in mimety… bpo-20392: Fix inconsistency with uppercase file extensions in mimetypes.guess_type Mar 15, 2022
@asvetlov asvetlov merged commit 5dd7ec5 into python:main Mar 15, 2022
@kumaraditya303 kumaraditya303 deleted the issue20392 branch March 15, 2022 13:28
@asvetlov asvetlov added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 15, 2022
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2022
@kumaraditya303 @miss-islington
bpo-20392: Fix inconsistency with uppercase file extensions in mimety…
90eac99 
…pes.guess_type (pythonGH-30229)

(cherry picked from commit 5dd7ec5)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 15, 2022
@bedevere-bot
Copy link

GH-31904 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2022
@kumaraditya303 @miss-islington
bpo-20392: Fix inconsistency with uppercase file extensions in mimety…
b618256 
…pes.guess_type (pythonGH-30229)

(cherry picked from commit 5dd7ec5)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Mar 15, 2022
@miss-islington @kumaraditya303
bpo-20392: Fix inconsistency with uppercase file extensions in mimety…
3c4f24f 
…pes.guess_type (GH-30229)

(cherry picked from commit 5dd7ec5)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Mar 15, 2022
@miss-islington @kumaraditya303
bpo-20392: Fix inconsistency with uppercase file extensions in mimety…
32ae9ab 
…pes.guess_type (GH-30229)

(cherry picked from commit 5dd7ec5)

Co-authored-by: Kumar Aditya <[email protected]>
@ifrh ifrh mentioned this pull request May 8, 2022
Open
@rodrigoparra rodrigoparra mannequin mentioned this pull request May 8, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @kumaraditya303 @hello-adam
bpo-20392: Fix inconsistency with uppercase file extensions in mimety…
84190ca 
…pes.guess_type (pythonGH-30229)

(cherry picked from commit 5dd7ec5)

Co-authored-by: Kumar Aditya <[email protected]>
@ifrh ifrh mentioned this pull request Jun 3, 2022
Merged
@hugovk hugovk removed the needs backport to 3.9 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@asvetlov asvetlov asvetlov approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kumaraditya303 @miss-islington @bedevere-bot @asvetlov @JelleZijlstra @sobolevn @hugovk @the-knights-who-say-ni