bpo-46245: Add optional parameter dir_fd in shutil.rmtree() #30365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
commented
Jan 4, 2022
Lib/shutil.py
Outdated
Comment on lines
686
to
689
| If dir_fd is not None, it should be a file descriptor open to a directory, | ||
| and path should be relative; path will then be relative to that directory. | ||
| dir_fd may not be implemented on your platform. | ||
| If it is unavailable, using it will raise a NotImplementedError. |
There was a problem hiding this comment.
It was copied from the docstring for os.rmdir(), but I don't like it. I'll change wording for os.rmdir() and others in separate issue.
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46245