Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-46066: catch DeprecationWarning #31428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2022
Merged

bpo-46066: catch DeprecationWarning #31428

merged 2 commits into from
Feb 20, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Feb 19, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Feb 19, 2022
sobolevn
sobolevn reviewed Feb 19, 2022
View reviewed changes
97littleleaf11
97littleleaf11 reviewed Feb 19, 2022
View reviewed changes
Copy link
Contributor

@97littleleaf11 97littleleaf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry that I missed the warnings. Thanks @tirkarthi for pointing out!

JelleZijlstra
JelleZijlstra commented Feb 19, 2022
View reviewed changes
sobolevn
sobolevn approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra
Copy link
Member Author

@gvanrossum Planning to merge this simple PR (fixes an oversight in the TD kwargs deprecation change; approved by Nikita).

gvanrossum
gvanrossum approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rephrase the commit message using “Check deprecation warning”.

@AlexWaygood AlexWaygood mentioned this pull request Feb 19, 2022
Closed
@JelleZijlstra JelleZijlstra merged commit 0a8a8e7 into python:main Feb 20, 2022
@JelleZijlstra JelleZijlstra deleted the tddepr branch February 20, 2022 01:44
@97littleleaf11 97littleleaf11 mannequin mentioned this pull request Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@97littleleaf11 97littleleaf11 97littleleaf11 left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@sobolevn sobolevn sobolevn approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JelleZijlstra @gvanrossum @sobolevn @97littleleaf11 @the-knights-who-say-ni @bedevere-bot