Remove new line in pickle error message #31782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is this change going to be implemented? If not, I'll just close. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
nanjekyejoannah
approved these changes
Oct 7, 2022
|
I think it's failing because there isn't an issue for this PR. Maybe I should delete the NEWS.d entry then? |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
@serhiy-storchaka - as someone who's been looking at pickle issue recently, do you see any problem with this change? Does it need a news entry? |
serhiy-storchaka
approved these changes
Nov 6, 2022
There was a problem hiding this comment.
It is a very old code. It was added in fdde96c.
I do not know reasons of adding a newline at the first place, but the change LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the new line in the error message. Encountered this while testing something and found it a little weird that there would be a new line character when the error message is short anyway.