Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-45150: Add hashlib.file_digest() for efficient file hashing #31930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 6 commits into from
Mar 22, 2022
Merged

bpo-45150: Add hashlib.file_digest() for efficient file hashing #31930

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71f0401
bpo-45150: Add hashlib.file_digest() for efficient file hashing
tiran Mar 16, 2022
85cee7f
Remove whitespace
tiran Mar 16, 2022
77df20d
Doctests are annoying
tiran Mar 16, 2022
67b8d7f
Address Greg's review comment
tiran Mar 17, 2022
8843102
Write file once
tiran Mar 21, 2022
689e5ec
Remove inner try/finally
tiran Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Write file once
  • Loading branch information
@tiran
tiran committed Mar 21, 2022
commit 884310285022e37199d7e89eab52b37d510ff8f8
12 changes: 7 additions & 5 deletions Lib/test/test_hashlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,22 +382,24 @@ def check_file_digest(self, name, data, hexdigest):
digests = [name]
digests.extend(self.constructors_to_test[name])

for digest in digests:
with self.subTest(digest=digest):
with open(os_helper.TESTFN, "wb") as f:
f.write(data)

try:
for digest in digests:
buf = io.BytesIO(data)
buf.seek(0)
self.assertEqual(
hashlib.file_digest(buf, digest).hexdigest(), hexdigest
Comment thread
gpshead marked this conversation as resolved.
)
with open(os_helper.TESTFN, "wb") as f:
f.write(data)
try:
with open(os_helper.TESTFN, "rb") as f:
digestobj = hashlib.file_digest(f, digest)
finally:
os.unlink(os_helper.TESTFN)
Comment thread
tiran marked this conversation as resolved.
Outdated
self.assertEqual(digestobj.hexdigest(), hexdigest)

finally:
os.unlink(os_helper.TESTFN)

def check_no_unicode(self, algorithm_name):
# Unicode objects are not allowed as input.
Expand Down