Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 26, 2022

This reverts commit a941e59 (GH-30194).

https://bugs.python.org/issue46126

Automerge-Triggered-By: GH:jaraco

@jaraco jaraco force-pushed the bpo-46126/revert branch from 0a9002d to a78511e Compare March 26, 2022 15:42
@jaraco jaraco requested a review from vstinner March 26, 2022 16:01
@jaraco
Copy link
Member Author

jaraco commented Mar 26, 2022

Victor, since you reviewed the previous change and expected to get value out of it, would you be so kind as to review this one as will in light of these findings?

@jaraco
Copy link
Member Author

jaraco commented Apr 3, 2022

I'll give this proposal another week for potential review and merge next week if no objection is raised.

@miss-islington miss-islington merged commit 84acb5c into main Apr 3, 2022
@miss-islington miss-islington deleted the bpo-46126/revert branch April 3, 2022 19:33
@gpshead
Copy link
Member

gpshead commented Apr 3, 2022

I'll give this proposal another week for potential review and merge next week if no objection is raised.

looks like approval triggered automatic merge. IMNSHO that is good, I disagree with the original PR that this one happily rolls back.
The docstring line in the unittest output is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants