Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-46712: share more global strings in deepfreeze #32152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2022
Merged

bpo-46712: share more global strings in deepfreeze #32152

merged 3 commits into from
Apr 19, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 28, 2022 •
edited by ericsnowcurrently
Loading

https://bugs.python.org/issue46712

(#90868)

@kumaraditya303 ➜ /workspaces/cpython (more-strings) $ cat Python/deepfreeze/deepfreeze.c | grep _Py_STR | wc -l
159

gvanrossum
gvanrossum reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepfreeze.py changes are okay, but I need @ericsnowcurrently to review the rest.

@gvanrossum gvanrossum requested review from ericsnowcurrently and removed request for markshannon March 28, 2022 15:52
@kumaraditya303
Copy link
Contributor Author

@gvanrossum Any update on this? Is this in Eric's review queue?

@gvanrossum
Copy link
Member

@ericsnowcurrently Please review.

ericsnowcurrently
ericsnowcurrently approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit ab0d35d into python:main Apr 19, 2022
@ericsnowcurrently
Copy link
Member

Thanks, @kumaraditya303! Sorry for the delay.

@kumaraditya303 kumaraditya303 deleted the more-strings branch September 26, 2022 11:03
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 10, 2022
Closed
This was referenced Apr 26, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kumaraditya303 @gvanrossum @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot