Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-85567: Register a cleanup function to close files for FileType objects in argparse #32257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facundobatista merged 2 commits into from
Apr 18, 2022
Merged

gh-85567: Register a cleanup function to close files for FileType objects in argparse #32257

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3600142
bpo-41395: Register a cleanup function to close files for FileType ob…
achhina Apr 2, 2022
a47430f
Added import as top level import, and renamed file as fh.
achhina Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added import as top level import, and renamed file as fh.
  • Loading branch information
@achhina
achhina committed Apr 14, 2022
commit a47430fff73363b0f21cc0d437eac738562c7643
10 changes: 4 additions & 6 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
'ZERO_OR_MORE',
]


import atexit as _atexit
import os as _os
import re as _re
import sys as _sys
Expand Down Expand Up @@ -1268,14 +1268,12 @@ def __call__(self, string):

# all other arguments are used as file names
try:
file = open(string, self._mode, self._bufsize, self._encoding,
self._errors)
fh = open(string, self._mode, self._bufsize, self._encoding, self._errors)

# Register cleanup function to close file
import atexit
atexit.register(file.close)
_atexit.register(fh.close)

return file
return fh
except OSError as e:
args = {'filename': string, 'error': e}
message = _("can't open '%(filename)s': %(error)s")
Expand Down