Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36329: Remove 'make -C Doc serve' in favour of 'make -C Doc htmlview' #32354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2022
Merged

bpo-36329: Remove 'make -C Doc serve' in favour of 'make -C Doc htmlview' #32354

merged 5 commits into from
Apr 29, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 6, 2022 •
edited
Loading

Matching Devguide PR: python/devguide#826.

Also updated make -C htmlview so it used a full path with file://, because the original didn't open the page (macOS).

For example:

cd Doc

# Doesn't open anything:
python3 -c "import webbrowser; webbrowser.open('build/html/index.html')"

# Opens the docs page e.g. file:///Users/hugo/github/cpython/Doc/build/html/index.html :
python3 -c "import os, webbrowser; webbrowser.open('file://' + os.path.realpath('build/html/index.html'))"

https://bugs.python.org/issue36329

@hugovk hugovk force-pushed the 36329-docs-make-htmlview branch from 6576b2e to 38747ae Compare April 6, 2022 09:07
This was referenced Apr 6, 2022
Merged
Closed
@encukou
Copy link
Member

encukou commented Apr 8, 2022 •
edited by bedevere-bot
Loading

Could you make serve echo The serve target was removed, use htmlview instead (see [bpo-36329](https://bugs.python.org/issue36329)), to help anyone still using it?
Also, could you keep the example in wsgiref docs? It has a purpose there. (Maybe it could be simplified to focus on serving, better commented, and moved to Doc/, of course. But it shouldn't be removed.)

@hugovk
Copy link
Member Author

hugovk commented Apr 8, 2022

Updated! How does this look?

encukou
encukou approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sorry for the delay, this fell off my list :(

@encukou encukou merged commit 89c6b2b into python:main Apr 29, 2022
@hugovk hugovk deleted the 36329-docs-make-htmlview branch April 29, 2022 15:08
@hugovk
Copy link
Member Author

hugovk commented Apr 29, 2022

Thanks for the review/merge! Any chance of checking the devguide one? python/devguide#826

@hugovk hugovk mentioned this pull request May 3, 2022
Closed
@hugovk hugovk mentioned this pull request Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @encukou @the-knights-who-say-ni @bedevere-bot