bpo-29271: Fix Task.current_task and Task.all_tasks to accept None. #406
Conversation
|
@1st1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @methane and @serhiy-storchaka to be potential reviewers. |
Misc/NEWS
Outdated
| @@ -688,6 +688,9 @@ Library | |||
| - Issue #24142: Reading a corrupt config file left configparser in an | |||
| invalid state. Original patch by Florian Höch. | |||
|
|
|||
| - Issue #29271: Fix Task.current_task and Task.all_tasks to accept | |||
There was a problem hiding this comment.
Move the entry to the start of the section. Mention that this fixes C implementation, makes it conforming to Python implementation.
There was a problem hiding this comment.
Aren't we usually appending news items instead of prepending?
Lib/test/test_asyncio/test_tasks.py
Outdated
| # See http://bugs.python.org/issue29271 for details: | ||
| asyncio.set_event_loop(loop) | ||
| try: | ||
| self.assertTrue(Task.current_task(None) is task) |
There was a problem hiding this comment.
Why not use assertIs()?
Misc/NEWS
Outdated
| @@ -256,6 +256,9 @@ Extension Modules | |||
| Library | |||
| ------- | |||
|
|
|||
| - Issue #29271: Fix Task.current_task and Task.all_tasks implemented in C | |||
There was a problem hiding this comment.
Now Misc/NEWS entries should be prefixed by "bpo-XXXXX" rather of "Issue #XXXXX".
|
Aren't we usually appending news items instead of prepending?
Entries in Misc/NEWS should be prepended. Entries in What's New usually are
appended.
|
|
Thank you for helping out Serhiy. It's my first PRs to the new GH repo so I'm getting accustomed to some new practices. |
|
@serhiy-storchaka BTW, to backport this to 3.6, do I need to create a new PR? Or I can just cherry-pick and push? |
|
AFAIK you can't push directly into this repository. You need to create a new
PR. Add the label "need to backport to 3.6" to this PR and "cherry-pick for
3.6" to the new PR.
|
See http://bugs.python.org/issue29271 for context. LGTM'ed by @methane