Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-34400: Fix undefined behavior in parsetok() #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Nov 17, 2017

Null pointers cannot be used in pointer arithmetic.

https://bugs.python.org/issue34400

@merwok
Copy link
Member

merwok commented Nov 17, 2017

Hello and thanks for your contribution!
This would need a ticket on bugs.python.org and probably a unit test.

@ZackerySpytz ZackerySpytz changed the title Fix undefined behavior in parsetok() bpo-34400: Fix undefined behavior in parsetok() Aug 14, 2018
@benjaminp benjaminp merged commit 7c4ab2a into python:master Aug 15, 2018
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8768 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8769 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2018
Avoid undefined pointer arithmetic with NULL.
(cherry picked from commit 7c4ab2a)

Co-authored-by: Zackery Spytz <[email protected]>
@bedevere-bot
Copy link

GH-8770 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2018
Avoid undefined pointer arithmetic with NULL.
(cherry picked from commit 7c4ab2a)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2018
Avoid undefined pointer arithmetic with NULL.
(cherry picked from commit 7c4ab2a)

Co-authored-by: Zackery Spytz <[email protected]>
@ZackerySpytz ZackerySpytz deleted the parsetok_ub branch August 15, 2018 06:31
miss-islington added a commit that referenced this pull request Aug 15, 2018
Avoid undefined pointer arithmetic with NULL.
(cherry picked from commit 7c4ab2a)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Aug 15, 2018
Avoid undefined pointer arithmetic with NULL.
(cherry picked from commit 7c4ab2a)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Aug 15, 2018
Avoid undefined pointer arithmetic with NULL.
(cherry picked from commit 7c4ab2a)

Co-authored-by: Zackery Spytz <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Aug 19, 2018
* master: (107 commits)
  bpo-22057: Clarify eval() documentation (pythonGH-8812)
  bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623)
  bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741)
  bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811)
  bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808)
  bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797)
  Improve error message when mock.assert_has_calls fails (pythonGH-8205)
  Warn not to set SIGPIPE to SIG_DFL (python#6773)
  bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796)
  bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
  bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787)
  bpo-34217: Use lowercase for windows headers (pythonGH-8472)
  bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756)
  bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775)
  bpo-34384: Fix os.readlink() on Windows (pythonGH-8740)
  closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439)
  bpo-34399: 2048 bits RSA keys and DH params (python#8762)
  Make regular expressions in test_tasks.py raw strings. (pythonGH-8759)
  smtplib documentation fixes (pythonGH-8708)
  Fix misindented yaml in logging how to example (pythonGH-8604)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants