bpo-32075: Expose ZipImporter Type Object in the include header files. #4470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully allow subclassing the zipimporter class outside of the Python layer as well.
Seems on Windows compile fails for some reason when in Python.h on a module.
Should be the last of my ZipImporter clinic problems.
brettcannon
reviewed
Nov 21, 2017
| extern "C" { | ||
| #endif | ||
|
|
||
| PyAPI_DATA(PyTypeObject) PyZipImporter_Type; |
There was a problem hiding this comment.
This and the rest of the file shouldn't be part of the stable ABI.
There was a problem hiding this comment.
But then how would someone be able to subclass or subtype the zip importer in their C code?
There was a problem hiding this comment.
Relying only on the stable ABI is an opt-in thing when you build an extension, so leaving this out of it won't prevent it from being available overall, just in a certain instance.
|
I personally don't have time to review and contemplate the ramifications of this, but I would suggest that any changes not be part of the stable ABI. |
|
zipimport have been rewritten in pure Python (bpo-25711). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully allow subclassing the zipimporter class outside of
the Python layer as well.
See the issue at bpo for more information as to why this needs exposed in the include files.
https://bugs.python.org/issue32075