Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-25095: test_httpservers hangs since Python 3.5 #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1,494 commits into from

Conversation

WildCard65
Copy link
Contributor

@WildCard65 WildCard65 commented Jan 4, 2018

RequestHandlerLoggingTestCase.test_get now sends a "Connection" header with
the value of "close" as the default state for HTTP/1.1 is to remain open.

https://bugs.python.org/issue25095

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@WildCard65 WildCard65 changed the title BPO-25095: Fix test_httpservers hanging on RequestHandlerLoggingTestCase.test_get… bpo-25095: Fix test_httpservers hanging on RequestHandlerLoggingTestCase.test_get… Jan 4, 2018
@WildCard65 WildCard65 force-pushed the bpo-25095 branch 2 times, most recently from 602642a to 789e85c Compare January 4, 2018 23:07
@WildCard65 WildCard65 changed the title bpo-25095: Fix test_httpservers hanging on RequestHandlerLoggingTestCase.test_get… bpo-25095: test_httpservers hangs since Python 3.5 Jan 27, 2018
@berkerpeksag berkerpeksag requested a review from vadmium July 27, 2018 12:54
@@ -0,0 +1,2 @@
RequestHandlerLoggingTestCase.test_get now sends a "Connection" header with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't require a NEWS entry for this issue, so I just set the "skip news" label. But it would be nice if we convert this into a comment in the test:

self.con.request('GET', '/', headers={'Connection': 'close'})

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately as stated in the linked BPO issue, the test hangs because the socket remains open and readable/writable as per HTTP 1.1, the test hangs as it awaits for the socket to terminate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm saying is that the Misc/NEWS.d/next/Tests/2018-01-27-13-21-39.bpo-25095.s-xRa5.rst file can be deleted (we don't require a NEWS entry for tests unless the patch is big) And we can add a comment to explain why we needed to add headers={'Connection': 'close'} in Lib/test/test_httpservers.py instead.

@WildCard65
Copy link
Contributor Author

WildCard65 commented Jul 27, 2018 via email

@berkerpeksag
Copy link
Member

Ok, I think I understand now, delete the news and add comment in code that
explains the change reason correct?

Correct :)

@WildCard65
Copy link
Contributor Author

Ok, I performed the change you asked.

@berkerpeksag
Copy link
Member

@vadmium do you have time to take a look at the latest version of the patch?

@vadmium
Copy link
Member

vadmium commented Aug 1, 2018

Now that I understand the problem, I think adding "Connection: close" is acceptable. Although IMO setting close_connection directly, or adding "Content-Length: 0" and cleaning up the client side, would be more robust.

* Add stdio_encoding and stdio_errors fields to _PyCoreConfig.
* Add unit tests on stdio_encoding and stdio_errors.
_PyCoreConfig_Read() is now responsible to choose the filesystem
encoding and error handler. Using Py_Main(), the encoding is now
chosen even before calling Py_Initialize().

_PyCoreConfig.filesystem_encoding is now the reference, instead of
Py_FileSystemDefaultEncoding, for the Python filesystem encoding.

Changes:

* Add filesystem_encoding and filesystem_errors to _PyCoreConfig
* _PyCoreConfig_Read() now reads the locale encoding for the file
  system encoding.
* PyUnicode_EncodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()
  now use the interpreter configuration rather than
  Py_FileSystemDefaultEncoding and Py_FileSystemDefaultEncodeErrors
  global configuration variables.
* Add _Py_SetFileSystemEncoding() and _Py_ClearFileSystemEncoding()
  private functions to only modify Py_FileSystemDefaultEncoding and
  Py_FileSystemDefaultEncodeErrors in coreconfig.c.
* _Py_CoerceLegacyLocale() now takes an int rather than
  _PyCoreConfig for the warning.
Call config_init_fs_encoding() if filesystem_errors is not NULL but
filesystem_encoding is NULL.
Py_DecodeLocale() and Py_EncodeLocale() now use the UTF-8 encoding on
Windows if Py_LegacyWindowsFSEncodingFlag is zero.

pymain_read_conf() now sets Py_LegacyWindowsFSEncodingFlag in its
loop, but restore its value at exit.
Add support for the "surrogatepass" error handler in
PyUnicode_DecodeFSDefault() and PyUnicode_EncodeFSDefault()
for the UTF-8 encoding.

Changes:

* _Py_DecodeUTF8Ex() and _Py_EncodeUTF8Ex() now support the
  surrogatepass error handler (_Py_ERROR_SURROGATEPASS).
* _Py_DecodeLocaleEx() and _Py_EncodeLocaleEx() now use
  the _Py_error_handler enum instead of "int surrogateescape" to pass
  the error handler. These functions now return -3 if the error
  handler is unknown.
* Add unit tests on _Py_DecodeLocaleEx() and _Py_EncodeLocaleEx()
  in test_codecs.
* Rename get_error_handler() to _Py_GetErrorHandler() and expose it
  as a private function.
* _freeze_importlib doesn't need config.filesystem_errors="strict"
  workaround anymore.
PYTHONCOERCELOCALE=warn warning is now emitted later and written into
sys.stderr, rather than being written into the C stderr stream.
* Py_FileSystemDefaultEncoding and Py_FileSystemDefaultEncodeErrors
  default value is now NULL: initfsencoding() set them
  during Python initialization.
* Document how Python chooses the filesystem encoding and error
  handler.
* Add an assertion to _PyCoreConfig_Read().
Use the core configuration of the interpreter, rather
than using global configuration variables. For example, replace
Py_QuietFlag with core_config->quiet.
Modify TestPosixSpawn to run Python using -I and -S options.

Disable site module to avoid side effects. For example, on Fedora 28,
if the HOME environment variable is not set, site._getuserbase()
calls pwd.getpwuid() which opens /var/lib/sss/mc/passwd, but then
leaves the file open which makes test_close_file() to fail.
@WildCard65
Copy link
Contributor Author

Been a while but @vadmium I added the header "Content-Length" alongside "Connection" (I kept the "Connection" header/value as it's part of the HTTP 1.1 protocol)

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@WildCard65
Copy link
Contributor Author

@vadmium @berkerpeksag Closing this PR caused I messed it up, recreated it at #9564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.