bpo-32221: makeipaddr(): remove interface part + speedup (GH-5449) #5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1st1 I fixed only tests comparing to previous try. Please review, but don't merge. I will double-check Linux, Windows and Mac OS X builds by hand. I will notify you when my manual checks will be done. |
|
@1st1 everything works as expected. Please review again and merge. |
|
Again: only tests were changed. |
|
@1st1 ping |
|
:( |
|
Please be a bit more patient. I was offline the last 10 days and couldn't take care of this. |
|
@1st1: Please replace |
|
Thanks @socketpair for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-5641 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2018
…) (pythonGH-5449) (cherry picked from commit 7766b96) Co-authored-by: Коренберг Марк <[email protected]>
1st1
pushed a commit
that referenced
this pull request
Feb 12, 2018
…H-5449) (#5641) (cherry picked from commit 7766b96) Co-authored-by: Коренберг Марк <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32221