bpo-34392: Add sys. _is_interned() #8755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Aug 13, 2018
| sys_isinterned_impl(PyObject *module, PyObject *string) | ||
| /*[clinic end generated code: output=0364c3f36499f868 input=2fe09bef8edf732e]*/ | ||
| { | ||
| return PyUnicode_CHECK_INTERNED(string); |
There was a problem hiding this comment.
Question: Currently sys.internmakes a PyUnicode_CheckExact(s) over the string so interning a subclass of a string gives a TypeError back. This returns False. Does it make sense to do a exact check to mirror the interface of sys.intern?
methane
approved these changes
Mar 28, 2019
|
@methane, should this be merged after fixing the merge conflicts? Thanks! |
Up to @serhiy-storchaka. He wanted this API to write some tests. |
methane
reviewed
May 9, 2022
Misc/NEWS.d/next/Core and Builtins/2018-08-13-13-25-15.bpo-34392.9kIlMF.rst
Outdated
Show resolved
Hide resolved
…92.9kIlMF.rst Co-authored-by: Inada Naoki <[email protected]>
iritkatriel
previously requested changes
Nov 25, 2022
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again. |
Merge conflicts are resolved.
Closed
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34392
#78573