Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat… #8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2018
Merged

bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat… #8869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eca162f
bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat…
Aug 23, 2018
3244a3f
Use Py_DECREF(delta) now that it can't be NULL at that point
Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,8 +1290,11 @@ tzinfo_from_isoformat_results(int rv, int tzoffset, int tz_useconds) {
}

PyObject *delta = new_delta(0, tzoffset, tz_useconds, 1);
if (delta == NULL) {
return NULL;
}
tzinfo = new_timezone(delta, NULL);
Py_XDECREF(delta);
Py_DECREF(delta);
} else {
tzinfo = Py_None;
Py_INCREF(Py_None);
Expand Down