gh-92032: Add soft keywords to rlcompleter #92029
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
Hi, I figured this one would skip issue / news |
|
I've added "skip issue", but if this is a bugfix that will result in a change in behaviour, I think a NEWS entry would probably be warranted :) |
|
Not a bugfix, with this the interpreter can autocomplete the match / case / _(wildcard pattern), which are as-of-now the only soft keywords added with PEP-634 |
In which case it is a feature, and there's even more need for it to have a news entry :) We generally only skip news for things like docs changes, minor typo fixes in comments, changes to the CI setup, etc.. Pretty much everything else needs an entry. |
|
To answer your request, given your repository rules, that would require a GH issue. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
squashed and reworded after NEWS entry generated by blurb-it |
Let the interpreter autocomplete soft-keywords, ATM the PEP-634 'match' / 'case' / '_' (wildcard pattern).
|
I have rebased because upstream has evolved since, however I don't know how that affects the process. |
Misc/NEWS.d/next/Core and Builtins/2022-04-28-20-19-49.gh-issue-92032.ef-UfM.rst
Outdated
Show resolved
Hide resolved
…e-92032.ef-UfM.rst
Rebasing is generally discouraged because it requires force pushing, which can make reviews harder. You can click the "update branch" button to bring the branch up to date with main. |
Misc/NEWS.d/next/Core and Builtins/2022-04-28-20-19-49.gh-issue-92032.ef-UfM.rst
Outdated
Show resolved
Hide resolved
…e-92032.ef-UfM.rst Co-authored-by: Alex Waygood <[email protected]>
Misc/NEWS.d/next/Core and Builtins/2022-04-28-20-19-49.gh-issue-92032.ef-UfM.rst
Outdated
Show resolved
Hide resolved
…e-92032.ef-UfM.rst
|
Last test is stuck |
I turned it off and on again |
|
Congrats on your first CPython contribution, @kbeldan! 😃 |
I've opened #92222, since this is also happening on my completely unrelated PR here: https://github.com/python/cpython/runs/6270908903?check_suite_focus=true @JelleZijlstra, do you know if there's any way of getting the logs from the run where the test failed, prior to it being switched off and on again? |
#92032