Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-92193: Check for overridden vectorcall field on PyFunctionObject #92194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented May 2, 2022

gh-92193: Check for overridden vectorcall field on PyFunctionObject

avoid specializing functions with overridden vectorcall field

@markshannon
Copy link
Member

I'm not sure that this makes sense by itself, as we never check vectorcall if version is non-zero.
If we add PyFunction_SetVectorCall() that sets version to zero, when it sets vectorcall, then this would work.

@itamaro
Copy link
Contributor Author

itamaro commented May 2, 2022

I'm not sure that this makes sense by itself, as we never check vectorcall if version is non-zero.

makes sense. we can do that, and/or move the vectorcall check to before the version check (and then maybe it does make sense by itself?). what do you think @markshannon ?

@itamaro
Copy link
Contributor Author

itamaro commented May 3, 2022

this PR is made obsolete by GH-92257

@itamaro itamaro closed this May 3, 2022
@itamaro itamaro deleted the check-modified-vectorcall branch March 22, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants