[3.9] gh-80254: Disallow recursive usage of cursors in sqlite3 converters
#92278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` converters (cherry picked from commit c908dc5) Co-authored-by: Sergey Fedoseev <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
May 4, 2022
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a5b9786 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 8e5fe56 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
For 3.9, 3.8, and 3.7, the cursor is not deallocated implicitly. I checked the code coverage, and the cursor dealloc function never run. Explicitly deleting the cursor in |
This was referenced May 5, 2022
JelleZijlstra
approved these changes
May 5, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…` converters (python#92278) * [3.9] pythongh-80254: Disallow recursive usage of cursors in `sqlite3` converters (cherry picked from commit c908dc5) Co-authored-by: Sergey Fedoseev <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> * Fix ref leak in pysqlite_cursor_iternext * Explicitly free resources at test tearDown()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c908dc5)
Co-authored-by: Sergey Fedoseev [email protected]
Co-authored-by: Jelle Zijlstra [email protected]