Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.8] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2022
Merged

[3.8] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92333

merged 3 commits into from
May 16, 2022

Conversation

erlend-aasland
Copy link
Contributor

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev [email protected]
Co-authored-by: Jelle Zijlstra [email protected]

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 88b09dc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
This was referenced May 5, 2022
Merged
Closed
@erlend-aasland
Copy link
Contributor Author

Buildbot comments (updating this post as they complete):

  • AMD64 FreeBSD Shared PR: compile failures; seems unrelated to this PR
  • ARM64 Windows PR: build tools missing; unrelated
  • ARM64 Windows Non-Debug PR: build tools missing; unrelated

@JelleZijlstra
Copy link
Member

The remaining failures (Gentoo, Fedora, Asan, Usan) are also on tests unrelated to SQLite. I don't have permissions to merge to this branch though.

@erlend-aasland
Copy link
Contributor Author

FTR, the buildbot failures all seem unrelated. Some are failed builds (missing build tools), others are unrelated test failures.

@vstinner
Copy link
Member

vstinner commented May 5, 2022 •
edited
Loading

The 3.8 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?

@JelleZijlstra
Copy link
Member

The 3.8 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?

Yes, because it fixes a segfault. #29054 (comment)

@vstinner
Copy link
Member

vstinner commented May 5, 2022

Ok, thanks.

@ambv ambv merged commit 69cf020 into python:3.8 May 16, 2022
@erlend-aasland erlend-aasland deleted the backport-sqlite-converter-segfault-3.8 branch May 16, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Tony-Frank-ML Tony-Frank-ML Tony-Frank-ML approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @bedevere-bot @JelleZijlstra @vstinner @Tony-Frank-ML @ambv