-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
[3.11] gh-91162: Fix substitution of unpacked tuples in generic aliases (GH-92335) #92484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
1 similar comment
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
Huh, the strings are tied to runtime state, which is tied to the ABI, so the ABI test is now failing. Should we regenerate the ABI data file or just change the code to lookup the C CC @pablogsal |
In this case, you can regenerate the ABI, but this will not be possible in the RC state |
@serhiy-storchaka: Status check is done, and it's a failure ❌ . |
How to merge this PR? |
@serhiy-storchaka please see this message, or the whole bpo issue. In the past, I had to get @pablogsal to regenerate it, because we don't have a devguide article on this and I was confused. |
I will merge this today. Will also try to add some information to the devguide, but in general the RM needs to approve ABI regenerations. |
pythonGH-92335) (cherry picked from commit 9d25db9) Co-authored-by: Serhiy Storchaka <[email protected]>
612e03d
to
8024c08
Compare
(cherry picked from commit 9d25db9)
Co-authored-by: Serhiy Storchaka [email protected]