Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.11] gh-91162: Fix substitution of unpacked tuples in generic aliases (GH-92335) #92484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit 9d25db9)

Co-authored-by: Serhiy Storchaka [email protected]

@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@Fidget-Spinner
Copy link
Member

Huh, the strings are tied to runtime state, which is tied to the ABI, so the ABI test is now failing. Should we regenerate the ABI data file or just change the code to lookup the C const char *(which will be slightly slower)?

CC @pablogsal

@pablogsal
Copy link
Member

Huh, the strings are tied to runtime state, which is tied to the ABI, so the ABI test is now failing. Should we regenerate the ABI data file or just change the code to look up the C const char *(which will be slightly slower)?

In this case, you can regenerate the ABI, but this will not be possible in the RC state

@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

@serhiy-storchaka
Copy link
Member

How to merge this PR?

@Fidget-Spinner
Copy link
Member

@serhiy-storchaka please see this message, or the whole bpo issue.

In the past, I had to get @pablogsal to regenerate it, because we don't have a devguide article on this and I was confused.

@pablogsal
Copy link
Member

I will merge this today. Will also try to add some information to the devguide, but in general the RM needs to approve ABI regenerations.

@pablogsal pablogsal force-pushed the backport-9d25db9-3.11 branch from 612e03d to 8024c08 Compare May 31, 2022 23:57
@pablogsal pablogsal merged commit 00f8fe9 into python:3.11 Jun 1, 2022
@miss-islington miss-islington deleted the backport-9d25db9-3.11 branch June 1, 2022 02:13
JelleZijlstra added a commit to python/typeshed that referenced this pull request Jun 3, 2022
AlexWaygood pushed a commit to python/typeshed that referenced this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants