gh-93040 Wrap unused parameters in Objects/obmalloc.c with Py_UNUSED #93175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @erlend-aasland @vstinner for your involvement in the issue. |
|
Merged, thanks. I don't think that this change should be backported, unless some C compilers emit many warnings when building Python 3.10 and 3.11. |
|
Thanks @vstinner @erlend-aasland! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #93040.
This PR wraps unused parameters with
Py_UNUSED()in the following functions fromobmalloc.c:_PyMem_RawMalloc_PyMem_RawCalloc_PyMem_RawRealloc_PyMem_RawFree_PyObject_ArenaVirtualAlloc_PyObject_ArenaVirtualFree_PyObject_ArenaMmap_PyObject_ArenaMunmap_PyObject_ArenaMalloc_PyObject_ArenaFreeaddress_in_rangepymalloc_allocpymalloc_freeaddress_in_range()is a special one out of this list as there are different versions of this function depending on the value of a macro. I have only addedPy_UNUSED()for the version that does not use thepoolparameter.