Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-93884: Improve test coverage of PyNumber_ToBase #93932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2022
Merged

gh-93884: Improve test coverage of PyNumber_ToBase #93932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d29cd3
improve test coverage of `PyNumber_ToBase`
CharlieZhao95 Jun 17, 2022
b2e45a1
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 17, 2022
c1e4586
Update 2022-06-17-13-27-21.gh-issue-93884.5pvPvl.rst
CharlieZhao95 Jun 17, 2022
fa39d8f
Test with a non-int class
CharlieZhao95 Jun 21, 2022
aa56ae7
Merge branch 'main' into gh-93884/improve_test_coverage
mdickinson Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions Lib/test/test_capi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,14 +753,30 @@ def meth(self):

def test_pynumber_tobase(self):
from _testcapi import pynumber_tobase
self.assertEqual(pynumber_tobase(123, 2), '0b1111011')
self.assertEqual(pynumber_tobase(123, 8), '0o173')
self.assertEqual(pynumber_tobase(123, 10), '123')
self.assertEqual(pynumber_tobase(123, 16), '0x7b')
self.assertEqual(pynumber_tobase(-123, 2), '-0b1111011')
self.assertEqual(pynumber_tobase(-123, 8), '-0o173')
self.assertEqual(pynumber_tobase(-123, 10), '-123')
self.assertEqual(pynumber_tobase(-123, 16), '-0x7b')
small_number = 123
large_number = 2**64
class IDX:
def __init__(self, val):
self.val = val
def __index__(self):
return self.val

test_cases = ((2, '0b1111011', '0b10000000000000000000000000000000000000000000000000000000000000000'),
(8, '0o173', '0o2000000000000000000000'),
(10, '123', '18446744073709551616'),
(16, '0x7b', '0x10000000000000000'))
for base, small_target, large_target in test_cases:
with self.subTest(base=base, st=small_target, lt=large_target):
# Test for small number
self.assertEqual(pynumber_tobase(small_number, base), small_target)
self.assertEqual(pynumber_tobase(-small_number, base), '-' + small_target)
self.assertEqual(pynumber_tobase(IDX(small_number), base), small_target)
# Test for large number(out of range of a longlong,i.e.[-2**63, 2**63-1])
self.assertEqual(pynumber_tobase(large_number, base), large_target)
self.assertEqual(pynumber_tobase(-large_number, base), '-' + large_target)
self.assertEqual(pynumber_tobase(IDX(large_number), base), large_target)
self.assertRaises(TypeError, pynumber_tobase, IDX(123.0), 10)
self.assertRaises(TypeError, pynumber_tobase, IDX('123'), 10)
self.assertRaises(TypeError, pynumber_tobase, 123.0, 10)
self.assertRaises(TypeError, pynumber_tobase, '123', 10)
self.assertRaises(SystemError, pynumber_tobase, 123, 0)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2022-06-17-13-27-21.gh-issue-93884.5pvPvl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add test cases for :c:func:`PyNumber_ToBase` that take a large number or a non-int object as parameter.