GH-77265: Document NaN handling in statistics functions that sort or count #94676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
stevendaprano
approved these changes
Jul 10, 2022
There was a problem hiding this comment.
This looks good to me. Thanks @rhettinger and @erlend-aasland
If I submit this with Approve, does that actually merge the changes?
|
Thanks @rhettinger for the PR, and @stevendaprano for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry @rhettinger and @stevendaprano, I had trouble checking out the |
|
GH-94725 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 10, 2022
…rt or count (pythonGH-94676) * Document NaN handling in functions that sort or count * Update Doc/library/statistics.rst Co-authored-by: Erlend Egeberg Aasland <[email protected]> * Update Doc/library/statistics.rst Co-authored-by: Erlend Egeberg Aasland <[email protected]> * Fix trailing whitespace and rewrap text Co-authored-by: Erlend Egeberg Aasland <[email protected]> (cherry picked from commit ef61b25) Co-authored-by: Raymond Hettinger <[email protected]>
|
Thanks @rhettinger for the PR, and @stevendaprano for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-94726 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 10, 2022
…rt or count (pythonGH-94676) * Document NaN handling in functions that sort or count * Update Doc/library/statistics.rst Co-authored-by: Erlend Egeberg Aasland <[email protected]> * Update Doc/library/statistics.rst Co-authored-by: Erlend Egeberg Aasland <[email protected]> * Fix trailing whitespace and rewrap text Co-authored-by: Erlend Egeberg Aasland <[email protected]> (cherry picked from commit ef61b25) Co-authored-by: Raymond Hettinger <[email protected]>
rhettinger
pushed a commit
that referenced
this pull request
Jul 10, 2022
rhettinger
pushed a commit
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the current state of affairs. Show users what the issue is and how they can avoid it.