Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-95079: document error behaviour for some unicode C APIs #95080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2024
Merged

GH-95079: document error behaviour for some unicode C APIs #95080

merged 9 commits into from
Sep 27, 2024

Conversation

maxbachmann
Copy link
Contributor

@maxbachmann maxbachmann commented Jul 21, 2022 •
edited by bedevere-bot
Loading

@ghost
Copy link

ghost commented Jul 21, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Jul 21, 2022
MaxwellDupre
MaxwellDupre reviewed Jul 21, 2022
View reviewed changes
MaxwellDupre
MaxwellDupre reviewed Jul 21, 2022
View reviewed changes
erlend-aasland
erlend-aasland requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please follow the existing style and use the imperative mood.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-bot bedevere-bot mentioned this pull request Nov 7, 2022
Open
maxbachmann
maxbachmann commented Jul 16, 2024
View reviewed changes
@maxbachmann
Copy link
Contributor Author

@erlend-aasland could you give this another look

erlend-aasland
erlend-aasland reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@maxbachmann
Copy link
Contributor Author

@erlend-aasland I did address your review comment. Is there anything else still missing?

erlend-aasland
erlend-aasland approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erlend-aasland erlend-aasland changed the title GH-95079: add missing documentation of error behavior GH-95079: document error behaviour for some unicode C APIs Sep 27, 2024
@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label Sep 27, 2024
@erlend-aasland erlend-aasland added the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
@erlend-aasland erlend-aasland merged commit b79a21e into python:main Sep 27, 2024
26 of 27 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@maxbachmann @miss-islington
pythonGH-95079: document error behaviour for some unicode C APIs (pyt…
1c11634 
…honGH-95080)

(cherry picked from commit b79a21e)

Co-authored-by: Max Bachmann <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124661 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@maxbachmann @miss-islington
pythonGH-95079: document error behaviour for some unicode C APIs (pyt…
31265e0 
…honGH-95080)

(cherry picked from commit b79a21e)

Co-authored-by: Max Bachmann <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124662 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 27, 2024
erlend-aasland pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @maxbachmann
[3.12] GH-95079: document error behaviour for some unicode C APIs (GH…
fb8d604 
…-95080) (#124662)

(cherry picked from commit b79a21e)

Co-authored-by: Max Bachmann <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @maxbachmann
[3.13] GH-95079: document error behaviour for some unicode C APIs (GH…
f6e23bb 
…-95080) (#124661)

GH-95079: document error behaviour for some unicode C APIs (GH-95080)
(cherry picked from commit b79a21e)

Co-authored-by: Max Bachmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxbachmann @bedevere-bot @erlend-aasland @MaxwellDupre