gh-95087: make email date parsing more robust #95089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
262ef76 to
cc496be
Compare
|
note to reviewers, the problems is the yy = yy[:-1]
if not yy[0].isdigit(): |
Similar to bpo-45001 (pythonGH-89164), this makes email date parsing more robust against malformed input. parsedate_tz() is supposed to return None for malformed input, but could crash on certain inputs, e.g. >>> email.utils.parsedate_tz('17 June , 2022') IndexError: string index out of range Fixes pythongh-95087.
cc496be to
ee122d3
Compare
There was a problem hiding this comment.
Thank you for your PR. There are other similar bugs in this function, so I created #95201 to fix them all.
| @@ -110,7 +110,7 @@ def _parsedate_tz(data): | |||
| yy, tm = tm, yy | |||
| if yy[-1] == ',': | |||
| yy = yy[:-1] | |||
| if not yy[0].isdigit(): | |||
| if yy and not yy[0].isdigit(): | |||
There was a problem hiding this comment.
Why not if not (yy and yy[0].isdigit())?
|
close via #95201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to bpo-45001 (GH-89164), this makes email date parsing more
robust against malformed input. parsedate_tz() is supposed to return
None for malformed input, but could crash on certain inputs, e.g.
Fixes gh-95087.