Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-34786: Fix wrong exception reference: BrokenThreadPool -> BrokenProcessPool #9533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

bpo-34786: Fix wrong exception reference: BrokenThreadPool -> BrokenProcessPool #9533

merged 1 commit into from
Sep 25, 2018

Conversation

kahara
Copy link
Contributor

@kahara kahara commented Sep 24, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 24, 2018
tirkarthi
tirkarthi approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me with https://bugs.python.org/issue34786#msg326234

@zhangyangyu zhangyangyu merged commit b60b468 into python:master Sep 25, 2018
@miss-islington
Copy link
Contributor

Thanks @kahara for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2018
@kahara @miss-islington
Fix wrong exception reference: BrokenThreadPool -> BrokenProcessPool (p…
5e82971 
…ythonGH-9533)

(cherry picked from commit b60b468)

Co-authored-by: Joni Kähärä <[email protected]>
@bedevere-bot
Copy link

GH-9554 is a backport of this pull request to the 3.7 branch.

@zhangyangyu zhangyangyu changed the title bpo-34786: refer to correct exception bpo-34786: Fix wrong exception reference: BrokenThreadPool -> BrokenProcessPool Sep 25, 2018
miss-islington added a commit that referenced this pull request Sep 25, 2018
@miss-islington @kahara
Fix wrong exception reference: BrokenThreadPool -> BrokenProcessPool (G…
bbdf872 
…H-9533)

(cherry picked from commit b60b468)

Co-authored-by: Joni Kähärä <[email protected]>
@kahara kahara deleted the kahara_fix_documentation_typo branch September 25, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kahara @the-knights-who-say-ni @miss-islington @bedevere-bot @tirkarthi @zooba @zhangyangyu