Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-95355: Check tokens[0] after allocating memory #95356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2022
Merged

gh-95355: Check tokens[0] after allocating memory #95356

merged 4 commits into from
Jul 28, 2022

Conversation

imzhuhl
Copy link
Contributor

@imzhuhl imzhuhl commented Jul 28, 2022 •
edited by miss-islington
Loading

#95355

Automerge-Triggered-By: GH:pablogsal

@ghost
Copy link

ghost commented Jul 28, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@CharlieZhao95
Copy link
Contributor

Good find.
p->tokens is a 2-dimensional pointer to Token *, p->tokens[0] is a pointer to Token structure.
In my opinion, it does need to be modified.

@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 28, 2022
@pablogsal
Copy link
Member

LGTM Good catch!

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b946f52 into python:main Jul 28, 2022
@miss-islington
Copy link
Contributor

Thanks @imzhuhl for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-95367 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
@imzhuhl @miss-islington
pythongh-95355: Check tokens[0] after allocating memory (pythonGH-95356)
c2fb6ca 
pythonGH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
@imzhuhl @miss-islington
pythongh-95355: Check tokens[0] after allocating memory (pythonGH-95356)
8cb867d 
pythonGH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <[email protected]>
@bedevere-bot
Copy link

GH-95368 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 28, 2022
miss-islington added a commit that referenced this pull request Jul 28, 2022
@miss-islington @imzhuhl
gh-95355: Check tokens[0] after allocating memory (GH-95356)
d3cc99b 
GH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <[email protected]>
miss-islington added a commit that referenced this pull request Jul 28, 2022
@miss-islington @imzhuhl
gh-95355: Check tokens[0] after allocating memory (GH-95356)
4513e4a 
GH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <[email protected]>
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imzhuhl @bedevere-bot @CharlieZhao95 @pablogsal @miss-islington @arhadthedev