[3.7] bpo-34791: xml package obeys ignore env flags (GH-9544) #9545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xml.sax and xml.dom.domreg modules now obey sys.flags.ignore_environment. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34791 (cherry picked from commit 223e501) Co-authored-by: Christian Heimes <[email protected]>
|
@tiran: Status check is done, and it's a success ✅ . |
1 similar comment
|
@tiran: Status check is done, and it's a success ✅ . |
|
@tiran Is this ready to merge to 3.7? |
|
@tiran: adding the "automerge" label doesn't work on automatically merge a PR once the CI pass. "automerge" still requires that a core dev approves the PR. For backports created by @miss-islington, approving the PR is enough: the "automerge" label is not needed. |
He already approved the backport by adding the "automerge" label, except that technically it wasn't enough to automatically merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue34791
(cherry picked from commit 223e501)
Co-authored-by: Christian Heimes [email protected]
https://bugs.python.org/issue34791