GH-92678: Make sure that tp_dictoffset
is correct when Py_TPFLAGS_MANAGED_DICT
is set
#95578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in making
Py_TPFLAGS_MANAGED_DICT
more usable for C extensions, or at least making the errors more easily understood.I still think the advice should be "don't use Py_TPFLAGS_MANAGED_DICT", but adding tests and making sure that
tp_dictoffset
andPy_TPFLAGS_MANAGED_DICT
are mutually consistent seems like a good idea.I'm skipping news as this doesn't add any features or actually fix anything.