Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-96143: Allow Linux perf profiler to see Python calls #96123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Aug 30, 2022
Merged

gh-96143: Allow Linux perf profiler to see Python calls #96123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
2a918e4
Allow Linux perf profiler to see Python calls
pablogsal Aug 7, 2022
cea1420
Add test
pablogsal Aug 20, 2022
4107c53
Update PCbuild/_freeze_module.vcxproj.filters
pablogsal Aug 20, 2022
5e34e66
munmap pages on shutdown, keep FILE open
tiran Aug 21, 2022
a26a850
Fix tests
pablogsal Aug 21, 2022
8170b24
Skip tests if sanitizer is active
pablogsal Aug 21, 2022
9df1c93
Add ARM64 code generated by aarch64-linux-gnu-gcc
tiran Aug 21, 2022
d8f396d
Address review comments
pablogsal Aug 21, 2022
d35c5d7
Secure fopen, use unraisable, continue on error
tiran Aug 22, 2022
2664b12
cleanup resources, set to uninit
tiran Aug 22, 2022
e6c365a
Allow to set custom callbacks
pablogsal Aug 22, 2022
5513fb1
Add comment to asm file
pablogsal Aug 22, 2022
76c7dc0
fixup! Merge pull request #36 from tiran/perf-file
pablogsal Aug 22, 2022
a545b3c
Add comments to the perf_trampoline file and format file
pablogsal Aug 22, 2022
5130c8d
Correct News entry
pablogsal Aug 22, 2022
991366b
Update Lib/test/test_perf_profiler.py
pablogsal Aug 22, 2022
0a0e53d
Rename perf macro
pablogsal Aug 22, 2022
7ea3371
Fix some typos
pablogsal Aug 22, 2022
680db66
Improve perf profiler tests
tiran Aug 22, 2022
1263a29
Add guard for initialization
pablogsal Aug 22, 2022
a42bde5
Add acks
pablogsal Aug 22, 2022
b780d2a
Initialize perf file lazily
pablogsal Aug 22, 2022
04bf416
Address review comments
pablogsal Aug 22, 2022
7558df2
Complain if there is already a evaluator frame when deactivating/acti…
pablogsal Aug 22, 2022
d1ebc88
Fix some errors on CI
pablogsal Aug 22, 2022
a83a31b
Reorder arguments to speed up trampoline
tiran Aug 22, 2022
0febd84
Preserve frame pointer
pablogsal Aug 22, 2022
dc5a6a5
Support perf backend and better handle forks
pablogsal Aug 22, 2022
be72b92
Fix more fork problems
pablogsal Aug 22, 2022
b5739f4
Update Lib/test/test_perf_profiler.py
pablogsal Aug 22, 2022
04c0c14
Handle missing backends
pablogsal Aug 22, 2022
e810ce6
Update Lib/test/test_perf_profiler.py
pablogsal Aug 22, 2022
bc8bf4e
clean up perf files
pablogsal Aug 22, 2022
0252845
Update Misc/NEWS.d/next/Core and Builtins/2022-08-20-18-36-40.gh-issu…
pablogsal Aug 22, 2022
264bed7
Test fork support, fix some fork problems and improve test file
pablogsal Aug 23, 2022
a31a498
Add more tests
pablogsal Aug 23, 2022
f591e8d
Update Objects/perf_trampoline.c
pablogsal Aug 23, 2022
0af2a08
make argument mandatory
pablogsal Aug 23, 2022
861ae09
Use struct for perf callbacks
tiran Aug 23, 2022
3058cf0
Rename macro to PY_HAVE_PERF_TRAMPOLINE
tiran Aug 23, 2022
07ee991
Merge pull request #39 from tiran/perf_callback_struct
pablogsal Aug 23, 2022
be612a9
Allow gdb to unwind
pablogsal Aug 23, 2022
f4e3fff
Merge remote-tracking branch 'upstream/main' into perf
pablogsal Aug 25, 2022
c27f8b1
Add docs
pablogsal Aug 25, 2022
e27a2c4
fixup! Add docs
pablogsal Aug 25, 2022
81c7f4b
fixup! fixup! Add docs
pablogsal Aug 25, 2022
ef0650b
Update sys API names in the NEWS entry.
gpshead Aug 29, 2022
d8932d2
Add environment variable
pablogsal Aug 29, 2022
0f303ff
Merge branch 'main' into perf
pablogsal Aug 29, 2022
e3f846e
Document the env var and the -X option
pablogsal Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename perf macro
  • Loading branch information
@pablogsal
pablogsal committed Aug 23, 2022
commit 0a0e53db1acfba60ddbad767fc4097828a38b437
14 changes: 7 additions & 7 deletions Objects/perf_trampoline.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ needed.
#include "pycore_frame.h"
#include "pycore_interp.h"

#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE

#include <fcntl.h>
#include <stdio.h>
Expand Down Expand Up @@ -373,12 +373,12 @@ py_trampoline_evaluator(PyThreadState *ts, _PyInterpreterFrame *frame,
// Something failed, fall back to the default evaluator.
return _PyEval_EvalFrameDefault(ts, frame, throw);
}
#endif // HAVE_PERF_TRAMPOLINE
#endif // _PY_HAVE_PERF_TRAMPOLINE

int
_PyIsPerfTrampolineActive(void)
{
#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE
PyThreadState *tstate = _PyThreadState_GET();
return tstate->interp->eval_frame == py_trampoline_evaluator;
#endif
Expand All @@ -390,7 +390,7 @@ _PyPerfTrampoline_SetCallbacks(trampoline_state_init init_state,
trampoline_state_write write_state,
trampoline_state_free free_state)
{
#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE
if (trampoline_api.state) {
Py_FatalError("Trampoline state already initialized");
return -1;
Expand All @@ -416,7 +416,7 @@ _PyPerfTrampoline_Init(int activate)
tstate->interp->eval_frame = NULL;
}
else {
#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE
tstate->interp->eval_frame = py_trampoline_evaluator;
if (new_code_arena() < 0) {
return -1;
Expand All @@ -429,7 +429,7 @@ _PyPerfTrampoline_Init(int activate)
int
_PyPerfTrampoline_Fini(void)
{
#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE
free_code_arenas();
trampoline_api.free_state(trampoline_api.state);
#endif
Expand All @@ -439,7 +439,7 @@ _PyPerfTrampoline_Fini(void)
PyStatus
_PyPerfTrampoline_AfterFork_Child(void)
{
#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE
// close file in child.
trampoline_api.free_state(trampoline_api.state);
#endif
Expand Down
2 changes: 1 addition & 1 deletion Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,7 +2037,7 @@ static PyObject *
sys_is_perf_trampoline_active_impl(PyObject *module)
/*[clinic end generated code: output=7bbf80001165b590 input=59f045e52c228654]*/
{
#ifdef HAVE_PERF_TRAMPOLINE
#ifdef _PY_HAVE_PERF_TRAMPOLINE
if (_PyIsPerfTrampolineActive()) {
Py_RETURN_TRUE;
}
Expand Down
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3436,7 +3436,7 @@ AS_CASE([$PLATFORM_TRIPLET],
AC_MSG_RESULT([$perf_trampoline])

AS_VAR_IF([perf_trampoline], [yes], [
AC_DEFINE([HAVE_PERF_TRAMPOLINE], [1], [Define to 1 if you have the perf trampoline.])
AC_DEFINE([_PY_HAVE_PERF_TRAMPOLINE], [1], [Define to 1 if you have the perf trampoline.])
PERF_TRAMPOLINE_OBJ=Objects/asm_trampoline.o
])
AC_SUBST([PERF_TRAMPOLINE_OBJ])
Expand Down
6 changes: 3 additions & 3 deletions pyconfig.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,9 +872,6 @@
/* Define to 1 if you have the `pause' function. */
#undef HAVE_PAUSE

/* Define to 1 if you have the perf trampoline. */
#undef HAVE_PERF_TRAMPOLINE

/* Define to 1 if you have the `pipe' function. */
#undef HAVE_PIPE

Expand Down Expand Up @@ -1802,6 +1799,9 @@
/* framework name */
#undef _PYTHONFRAMEWORK

/* Define to 1 if you have the perf trampoline. */
#undef _PY_HAVE_PERF_TRAMPOLINE

/* Define to force use of thread-safe errno, h_errno, and other functions */
#undef _REENTRANT

Expand Down