gh-91001: dict: Remove unused DK_IXSIZE macro #96405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 9833bb9 landed, there's no user of DK_IXSIZE left. Not even a test. So it's saver to remove it, instead of risking bit-rot.
|
thanks |
|
Thanks @matthiasgoergens for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2022
(cherry picked from commit d21d2f0) Co-authored-by: Matthias Görgens <[email protected]>
|
GH-96406 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Aug 30, 2022
(cherry picked from commit d21d2f0) Co-authored-by: Matthias Görgens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 9833bb9 landed, there's no user
of DK_IXSIZE left.
Not even a test.
So it's safer to remove it, instead of risking bit-rot.