gh-96448: fix documentation for _thread.lock.acquire #96449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
approved these changes
Sep 26, 2022
|
Thanks @dgiger42 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-97851 is a backport of this pull request to the 3.11 branch. |
|
GH-97852 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2022
…96449) * fix documentation for _thread.lock.acquire * update formatting of _thread.lock.acquire() doc (cherry picked from commit 7acb93f) Co-authored-by: Daniel Giger <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2022
…96449) * fix documentation for _thread.lock.acquire * update formatting of _thread.lock.acquire() doc (cherry picked from commit 7acb93f) Co-authored-by: Daniel Giger <[email protected]>
orsenthil
pushed a commit
that referenced
this pull request
Oct 4, 2022
#97851) gh-96448: fix documentation for _thread.lock.acquire (GH-96449) * fix documentation for _thread.lock.acquire * update formatting of _thread.lock.acquire() doc (cherry picked from commit 7acb93f) Co-authored-by: Daniel Giger <[email protected]> Co-authored-by: Daniel Giger <[email protected]>
orsenthil
pushed a commit
that referenced
this pull request
Oct 4, 2022
#97852) gh-96448: fix documentation for _thread.lock.acquire (GH-96449) * fix documentation for _thread.lock.acquire * update formatting of _thread.lock.acquire() doc (cherry picked from commit 7acb93f) Co-authored-by: Daniel Giger <[email protected]> Co-authored-by: Daniel Giger <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
#97851) gh-96448: fix documentation for _thread.lock.acquire (GH-96449) * fix documentation for _thread.lock.acquire * update formatting of _thread.lock.acquire() doc (cherry picked from commit 7acb93f) Co-authored-by: Daniel Giger <[email protected]> Co-authored-by: Daniel Giger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fairly trivial, so I think it probably doesn't need a news entry. This PR updates the documentation for
_thread.lock.acquire()to use the correct name for its first parameter.I also switched to saying
TrueandFalseinstead of1and0, which is consistent with the function'sPyDoc_STRVAR.