Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-96455: update example in exception_handling_notes.txt to the 3.11RC bytecode #96456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2022
Merged

gh-96455: update example in exception_handling_notes.txt to the 3.11RC bytecode #96456

merged 3 commits into from
Sep 1, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 31, 2022 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel added docs Documentation in the Doc dir skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes labels Aug 31, 2022
MatthieuDartiailh
MatthieuDartiailh reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@MatthieuDartiailh MatthieuDartiailh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 91 of the patched version there is still a mention of pushing the exception as three values. If a single POP_TOP is necessary I assume the exception is pushed as a single value, no ?

@iritkatriel
Copy link
Member Author

On line 91 of the patched version there is still a mention of pushing the exception as three values. If a single POP_TOP is necessary I assume the exception is pushed as a single value, no ?

Thanks - I've fixed that now.

markshannon
markshannon reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM.

@iritkatriel iritkatriel merged commit a91f255 into python:main Sep 1, 2022
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-96477 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2022
@iritkatriel @miss-islington
pythongh-96455: update example in exception_handling_notes.txt to the…
08fdfed 
… 3.11RC bytecode (pythonGH-96456)

(cherry picked from commit a91f255)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington added a commit that referenced this pull request Sep 1, 2022
@miss-islington @iritkatriel
gh-96455: update example in exception_handling_notes.txt to the 3.11R…
5835911 
…C bytecode (GH-96456)

(cherry picked from commit a91f255)

Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel iritkatriel deleted the gh-96455 branch October 18, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthieuDartiailh MatthieuDartiailh MatthieuDartiailh left review comments

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exception_handling_notes is out of date
5 participants
@iritkatriel @miss-islington @bedevere-bot @MatthieuDartiailh @markshannon