Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-72719: Remove deprecated asyncore and asynchat modules #96580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 7 commits into from
Nov 8, 2022
Merged

gh-72719: Remove deprecated asyncore and asynchat modules #96580

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99e3de9
gh-72719: Remove deprecated `asyncore` and `asynchat` modules
sobolevn Sep 5, 2022
9a49615
Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU…
sobolevn Oct 7, 2022
4b7d32d
Address review
sobolevn Oct 28, 2022
968ef31
Address review
sobolevn Nov 5, 2022
c50f6b7
Remove last mentions of modules
sobolevn Nov 7, 2022
c1b225b
Merge main into issue-72719
sobolevn Nov 8, 2022
ecd04df
Restore license
sobolevn Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU… 
…pzF3.rst

Co-authored-by: Jelle Zijlstra <[email protected]>
  • Loading branch information
@sobolevn @JelleZijlstra
sobolevn and JelleZijlstra authored Oct 7, 2022
commit 9a4961573441fe2a4f89edcd5673ea16c997939f
5 changes: 2 additions & 3 deletions Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
Remove deprecated as per :pep:`594` modules :mod:`asyncore` and :mod:`asynchat`.
Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.

They are moved to ``test.support`` so, some other tests that rely on them keep
working.
They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.
Copy link
Copy Markdown
Member

@vstinner vstinner Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

Copy link
Copy Markdown
Member Author

@sobolevn sobolevn Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for the review!