-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-34576 warn users on security for http.server #9720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It was proposed to add an warning for http.server regarding security issues. The wording was provided at bpo-26005 by @orsenthil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@orsenthil: Please replace |
Thanks @fbidu for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Thanks @fbidu for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
It was proposed to add an warning for http.server regarding security issues. The wording was provided at bpo-26005 by @orsenthil (cherry picked from commit 1d26c72) Co-authored-by: Felipe Rodrigues <[email protected]>
GH-9794 is a backport of this pull request to the 3.6 branch. |
It was proposed to add an warning for http.server regarding security issues. The wording was provided at bpo-26005 by @orsenthil (cherry picked from commit 1d26c72) Co-authored-by: Felipe Rodrigues <[email protected]>
GH-9795 is a backport of this pull request to the 3.7 branch. |
@orsenthil I made a small fix in the wording of the sentence, the commit did not appear here because of the merging... Is it possible to reopen it? |
@fbidu - what is the fix? I reviewed before the merge and found the current change ok. |
If anything significant, we will have bring it in as a separate patch. |
It was proposed to add an warning for http.server regarding security issues. The wording was provided at bpo-26005 by @orsenthil (cherry picked from commit 1d26c72) Co-authored-by: Felipe Rodrigues <[email protected]>
It was proposed to add an warning for http.server regarding security issues. The wording was provided at bpo-26005 by @orsenthil (cherry picked from commit 1d26c72) Co-authored-by: Felipe Rodrigues <[email protected]>
@orsenthil I changed "does not implement the stringent security checks needed of real HTTP server" to "does not implement the stringent security checks needed for a real HTTP server". I think 'need for' makes more sense |
It was proposed to add an warning for http.server regarding security
issues. The wording was provided at bpo-26005 by @orsenthil
I created a section called "Security Considerations" as recommended in Documenting Python
This needs to be backported to the Python 2 docs for SimpleHTTPServer but I'm not really sure how should I proceed to do that.
https://bugs.python.org/issue34576