gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles #98459

AlexTate · 2022-10-19T18:15:03Z

Closes #98458

Issue: Unittest: self-referencing explicit exception cause results in infinite loop #98458

…ed exception in TestResult._clean_tracebacks()

bedevere-bot · 2022-10-19T18:15:09Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

ghost · 2022-10-19T18:15:33Z

All commit authors signed the Contributor License Agreement.

zware

Can you add a test for this? It would be good to also test the more exotic case of a loop of mutually-chained exceptions, such as:

try:
    raise ValueError(1)
except ValueError as e:
    try:
        raise KeyError(2) from e
    except KeyError as e2:
        raise e from e2

Lib/unittest/result.py

kumaraditya303

Please add a test for this and address @iritkatriel's review.

bedevere-bot · 2022-11-27T06:55:52Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@iritkatriel

…cks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out)

AlexTate · 2022-12-01T23:25:01Z

I have made the requested changes; please review again

bedevere-bot · 2022-12-01T23:25:05Z

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

test added

iritkatriel

Looks good, I'd add another test.

Lib/test/test_unittest/test_result.py

Lib/unittest/result.py

…olds a self-loop in its __cause__ and __context__ attributes

iritkatriel

LGTM.

@gpshead - as a maintainer of unittest, do you want to backport this?

miss-islington · 2022-12-04T19:37:59Z

Thanks @AlexTate for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-12-04T19:38:19Z

GH-99995 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2022-12-04T19:38:24Z

GH-99996 is a backport of this pull request to the 3.10 branch.

@iritkatriel

…ined exceptions that contain cycles (pythonGH-98459) * Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks() * Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out) * adds a test for a single chained exception that holds a self-loop in its __cause__ and __context__ attributes (cherry picked from commit 72ec518) Co-authored-by: AlexTate <[email protected]>

@iritkatriel

…ined exceptions that contain cycles (pythonGH-98459) * Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks() * Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out) * adds a test for a single chained exception that holds a self-loop in its __cause__ and __context__ attributes (cherry picked from commit 72ec518) Co-authored-by: AlexTate <[email protected]>

@iritkatriel

…xceptions that contain cycles (GH-98459) * Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks() * Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out) * adds a test for a single chained exception that holds a self-loop in its __cause__ and __context__ attributes (cherry picked from commit 72ec518) Co-authored-by: AlexTate <[email protected]>

@iritkatriel

…xceptions that contain cycles (GH-98459) * Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks() * Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out) * adds a test for a single chained exception that holds a self-loop in its __cause__ and __context__ attributes (cherry picked from commit 72ec518) Co-authored-by: AlexTate <[email protected]>

Bugfix addressing infinite loop while handling self-referencing chain…

2defc0e

…ed exception in TestResult._clean_tracebacks()

bedevere-bot added the awaiting review label Oct 19, 2022

📜🤖 Added by blurb_it.

bfe8a4a

zware reviewed Oct 19, 2022

View reviewed changes

iritkatriel reviewed Oct 20, 2022

View reviewed changes

Lib/unittest/result.py Show resolved Hide resolved

kumaraditya303 previously requested changes Nov 27, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Nov 27, 2022

Bugfix extended to properly handle exception cycles in _clean_traceba…

c100409

…cks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out)

bedevere-bot mentioned this pull request Dec 1, 2022

Unittest: self-referencing explicit exception cause results in infinite loop #98458

Closed

Merge branch 'main' into issue-98458

fa84a5b

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 1, 2022

bedevere-bot requested a review from kumaraditya303 December 1, 2022 23:25

kumaraditya303 requested a review from iritkatriel December 2, 2022 12:44

bedevere-bot added awaiting review and removed awaiting change review labels Dec 2, 2022

AlexTate changed the title ~~gh-98458: unittest: bugfix for infinite loop while handling self-referencing explicit exception~~ gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles Dec 2, 2022

iritkatriel reviewed Dec 2, 2022

View reviewed changes

Lib/test/test_unittest/test_result.py Outdated Show resolved Hide resolved

Lib/test/test_unittest/test_result.py Show resolved Hide resolved

Lib/unittest/result.py Outdated Show resolved Hide resolved

AlexTate added 4 commits December 3, 2022 09:37

Requested change: removing unnecessary comment lines

8388d82

Requested change: clarify comment in _clean_tracebacks()

08fd984

Requested change: adding a test for a single chained exception that h…

6b868df

…olds a self-loop in its __cause__ and __context__ attributes

Merge branch 'main' into issue-98458

d7aa4e7

iritkatriel approved these changes Dec 4, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Dec 4, 2022

iritkatriel added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir labels Dec 4, 2022

gpshead added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 4, 2022

gpshead approved these changes Dec 4, 2022

View reviewed changes

gpshead merged commit 72ec518 into python:main Dec 4, 2022

bedevere-bot removed the awaiting merge label Dec 4, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 4, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles #98459

gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles #98459

Uh oh!

AlexTate commented Oct 19, 2022 •

edited by bedevere-bot

Loading

Uh oh!

bedevere-bot commented Oct 19, 2022

Uh oh!

ghost commented Oct 19, 2022 •

edited by ghost

Loading

Uh oh!

zware left a comment

Uh oh!

Uh oh!

kumaraditya303 left a comment

Uh oh!

bedevere-bot commented Nov 27, 2022

Uh oh!

AlexTate commented Dec 1, 2022

Uh oh!

bedevere-bot commented Dec 1, 2022

Uh oh!

iritkatriel left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iritkatriel left a comment

Uh oh!

miss-islington commented Dec 4, 2022

Uh oh!

bedevere-bot commented Dec 4, 2022

Uh oh!

bedevere-bot commented Dec 4, 2022

Uh oh!

Uh oh!

Uh oh!

gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles #98459

gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles #98459

Uh oh!

Conversation

AlexTate commented Oct 19, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Oct 19, 2022

Uh oh!

ghost commented Oct 19, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 27, 2022

Uh oh!

AlexTate commented Dec 1, 2022

Uh oh!

bedevere-bot commented Dec 1, 2022

Uh oh!

iritkatriel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iritkatriel left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Dec 4, 2022

Uh oh!

bedevere-bot commented Dec 4, 2022

Uh oh!

bedevere-bot commented Dec 4, 2022

Uh oh!

Uh oh!

AlexTate commented Oct 19, 2022 •

edited by bedevere-bot

Loading

ghost commented Oct 19, 2022 •

edited by ghost

Loading