Stop using deprecated logging API in Sphinx #9875

pablogsal · 2018-10-14T16:56:46Z

The doc target can fail due to the use of a deprecated logging API in
Doc/tools/extensions/suspicious.py and treating warnings as errors. Example error:

$ make check suspicious html SPHINXOPTS="-q -W -j4"
python3 tools/rstlint.py -i tools -i ./venv -i README.rst
No problems found.
make[1]: Entering directory `/home/travis/build/python/cpython/Doc'
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b suspicious -d build/doctrees -D latex_elements.papersize= -q -W -j4 . build/suspicious 
/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/sphinx/application.py:402: RemovedInSphinx20Warning: app.info() is now deprecated. Use sphinx.util.logging instead.
  RemovedInSphinx20Warning)

GH-9875)" This reverts commit ee171a2.

* master: (621 commits) Update opcode.h header comment to mention the source data file (pythonGH-9935) bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pythonGH-9760) Updated documentation on logging.debug(). (pythonGH-9946) bpo-34765: Update the install-sh file (pythonGH-9592) bpo-35008: Fix possible leaks in Element.__setstate__(). (pythonGH-9924) bpo-35011: Restore use of pyexpatns.h in libexpat (pythonGH-9939) bpo-24658: Fix read/write greater than 2 GiB on macOS (pythonGH-1705) Add missing comma to wsgiref doc (pythonGH-9932) bpo-23420: Verify the value of '-s' when execute the CLI of cProfile (pythonGH-9925) Doc: Fix is_prime (pythonGH-9909) In email docs, correct spelling of foregoing (python#9856) In email.parser in message_from_bytes, update `strict` to `policy` (python#9854) bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (pythonGH-9913) Added CLI starter example to logging cookbook. (pythonGH-9910) bpo-34783: Fix test_nonexisting_script() (pythonGH-9896) bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (pythonGH-9859) bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889) Stop using deprecated logging API in Sphinx suspicious checker (pythonGH-9875) fix dangling keyfunc examples in documentation of heapq and sorted (python#1432) bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter (pythonGH-9703) ...

* master: (1787 commits) Update opcode.h header comment to mention the source data file (pythonGH-9935) bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pythonGH-9760) Updated documentation on logging.debug(). (pythonGH-9946) bpo-34765: Update the install-sh file (pythonGH-9592) bpo-35008: Fix possible leaks in Element.__setstate__(). (pythonGH-9924) bpo-35011: Restore use of pyexpatns.h in libexpat (pythonGH-9939) bpo-24658: Fix read/write greater than 2 GiB on macOS (pythonGH-1705) Add missing comma to wsgiref doc (pythonGH-9932) bpo-23420: Verify the value of '-s' when execute the CLI of cProfile (pythonGH-9925) Doc: Fix is_prime (pythonGH-9909) In email docs, correct spelling of foregoing (python#9856) In email.parser in message_from_bytes, update `strict` to `policy` (python#9854) bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (pythonGH-9913) Added CLI starter example to logging cookbook. (pythonGH-9910) bpo-34783: Fix test_nonexisting_script() (pythonGH-9896) bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (pythonGH-9859) bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889) Stop using deprecated logging API in Sphinx suspicious checker (pythonGH-9875) fix dangling keyfunc examples in documentation of heapq and sorted (python#1432) bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter (pythonGH-9703) ...

miss-islington · 2019-06-09T00:47:38Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington · 2019-06-09T00:47:38Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot · 2019-06-09T00:47:53Z

GH-13923 is a backport of this pull request to the 3.6 branch.

bedevere-bot · 2019-06-09T00:47:59Z

GH-13924 is a backport of this pull request to the 3.7 branch.

…nGH-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

miss-islington · 2019-06-09T00:50:36Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

bedevere-bot · 2019-06-09T00:50:46Z

GH-13925 is a backport of this pull request to the 2.7 branch.

…nGH-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

(cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

…) (GH-13923) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

miss-islington · 2019-10-08T03:02:42Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

miss-islington · 2019-10-08T03:02:47Z

Sorry @pablogsal, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ee171a26c1169abfae534b08acc0d95c6e45a22a 2.7

…H-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

pablogsal added skip issue skip news labels Oct 14, 2018

the-knights-who-say-ni added the CLA signed label Oct 14, 2018

bedevere-bot added the awaiting merge label Oct 14, 2018

Stop using deprecated logging API in Sphinx

fa6ad3a

pablogsal force-pushed the fix_sphinx branch from 4bd814a to fa6ad3a Compare October 14, 2018 16:57

ned-deily requested a review from JulienPalard October 15, 2018 02:42

brettcannon approved these changes Oct 15, 2018

View reviewed changes

pablogsal merged commit ee171a2 into python:master Oct 15, 2018

pablogsal deleted the fix_sphinx branch October 15, 2018 19:07

bedevere-bot removed the awaiting merge label Oct 15, 2018

vstinner added a commit that referenced this pull request Oct 16, 2018

Revert "Stop using deprecated logging API in Sphinx suspicious checker (

0f4cec0

GH-9875)" This reverts commit ee171a2.

ned-deily added needs backport to 3.6 labels Jun 9, 2019

bedevere-bot removed the needs backport to 3.6 label Jun 9, 2019

bedevere-bot removed the needs backport to 3.7 label Jun 9, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019

Stop using deprecated logging API in Sphinx suspicious checker (pytho…

39ffa42

…nGH-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019

Stop using deprecated logging API in Sphinx suspicious checker (pytho…

8d9e4ea

…nGH-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

ned-deily added the needs backport to 2.7 label Jun 9, 2019

bedevere-bot removed the needs backport to 2.7 label Jun 9, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019

Stop using deprecated logging API in Sphinx suspicious checker (pytho…

9837e9b

…nGH-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

miss-islington added a commit that referenced this pull request Jun 9, 2019

Stop using deprecated logging API in Sphinx suspicious checker (GH-9875)

3621bf2

(cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

ned-deily pushed a commit that referenced this pull request Jun 9, 2019

Stop using deprecated logging API in Sphinx suspicious checker (GH-9875…

9393e19

…) (GH-13923) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

benjaminp added the needs backport to 2.7 label Oct 8, 2019

miss-islington assigned pablogsal Oct 8, 2019

benjaminp pushed a commit that referenced this pull request Oct 8, 2019

[2.7] Stop using deprecated logging API in Sphinx suspicious checker (G…

86971d4

…H-9875) (cherry picked from commit ee171a2) Co-authored-by: Pablo Galindo <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Stop using deprecated logging API in Sphinx #9875

Stop using deprecated logging API in Sphinx #9875

Uh oh!

pablogsal commented Oct 14, 2018 •

edited

Loading

Uh oh!

miss-islington commented Jun 9, 2019

Uh oh!

miss-islington commented Jun 9, 2019

Uh oh!

bedevere-bot commented Jun 9, 2019

Uh oh!

bedevere-bot commented Jun 9, 2019

Uh oh!

miss-islington commented Jun 9, 2019

Uh oh!

bedevere-bot commented Jun 9, 2019

Uh oh!

miss-islington commented Oct 8, 2019

Uh oh!

miss-islington commented Oct 8, 2019

Uh oh!

Uh oh!

Uh oh!

Stop using deprecated logging API in Sphinx #9875

Stop using deprecated logging API in Sphinx #9875

Uh oh!

Conversation

pablogsal commented Oct 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Jun 9, 2019

Uh oh!

miss-islington commented Jun 9, 2019

Uh oh!

bedevere-bot commented Jun 9, 2019

Uh oh!

bedevere-bot commented Jun 9, 2019

Uh oh!

miss-islington commented Jun 9, 2019

Uh oh!

bedevere-bot commented Jun 9, 2019

Uh oh!

miss-islington commented Oct 8, 2019

Uh oh!

miss-islington commented Oct 8, 2019

Uh oh!

Uh oh!

pablogsal commented Oct 14, 2018 •

edited

Loading