Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-90868: Adjust the Generated Objects #99223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 8, 2022
Merged

gh-90868: Adjust the Generated Objects #99223

merged 6 commits into from
Nov 8, 2022

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Nov 8, 2022 •
edited by bedevere-bot
Loading

We do the following:

  • move the generated _PyUnicode_InitStaticStrings() to its own file
  • move the generated _PyStaticObjects_CheckRefcnt() to its own file
  • include pycore_global_objects.h in extension modules instead of pycore_runtime_init.h

These changes help us avoid including things that aren't needed.

@bedevere-bot bedevere-bot mentioned this pull request Nov 8, 2022
Closed
@ericsnowcurrently ericsnowcurrently force-pushed the generated-objects-cleanup branch from 6e434d8 to aa76fcc Compare November 8, 2022 01:27
@ericsnowcurrently ericsnowcurrently merged commit 52f91c6 into python:main Nov 8, 2022
@ericsnowcurrently ericsnowcurrently deleted the generated-objects-cleanup branch November 8, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @bedevere-bot