Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-97514: Authenticate the forkserver control socket. #99309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 20, 2024
Merged

gh-97514: Authenticate the forkserver control socket. #99309

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d82afc8
Authenticate the forkserver control socket.
gpshead Nov 10, 2022
72f3843
improve some error handling and add a test.
gpshead Nov 11, 2022
c83193d
NEWS entry.
gpshead Nov 11, 2022
14f6f4d
Fix refleaks in the test.
gpshead Nov 13, 2022
8c5f7f4
minor news wording tweak.
gpshead Nov 13, 2022
ca47b6f
fix the hang on macOS by removing part of the test.
gpshead Nov 13, 2022
6f8e22f
clear up some comments and an assert
gpshead Nov 15, 2022
3bbbda7
Merge branch 'main' into security/multiprocessing-forkserver-authkey
gpshead Jun 21, 2023
0119b6a
Merge branch 'main' into security/multiprocessing-forkserver-authkey
gpshead Sep 24, 2024
ab9f93d
Add a comment about the fd recv acks.
gpshead Sep 24, 2024
7d41b16
Merge branch 'main' into security/multiprocessing-forkserver-authkey
gpshead Nov 10, 2024
6bb9db4
Address review comments: simplify & comment.
gpshead Nov 10, 2024
9c22c06
Add a whatsnew entry.
gpshead Nov 10, 2024
07c01d4
missing : sphinx-lint
gpshead Nov 10, 2024
a53c01f
Minor edits per @.picnixz code review comments.
gpshead Nov 10, 2024
db29006
Merge branch 'main' into security/multiprocessing-forkserver-authkey
gpshead Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NEWS entry.
  • Loading branch information
@gpshead
gpshead committed Nov 11, 2022
commit c83193dc5645de8b6f9d33d5fe7a013a1bf88b6e
10 changes: 10 additions & 0 deletions Misc/NEWS.d/next/Library/2022-11-10-17-16-45.gh-issue-97514.kzA0zl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Authentication was added to the :mod:`multiprocessing` forkserver start
method control socket so that only processes with the authentication key
generated by the process that spawned the forkserver can control it. This
is an enhancement over the other :gh:`97514` fixes so that access is no
longer limited only by filesystem permissions.

The file descriptor exchange of control pipes with the worker forked worker
process now requires an explicit acknowledgement byte to be sent over the
socket after the exchange on all forkserver supporting platforms. That makes
testing the above much easier.