Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-99537: Use Py_SETREF() function in C code #99657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

gh-99537: Use Py_SETREF() function in C code #99657

merged 1 commit into from
Nov 22, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 21, 2022 •
edited by bedevere-bot
Loading

Fix potential race condition in code patterns:

  • Replace "Py_DECREF(var); var = new;" with "Py_SETREF(var, new);"
  • Replace "Py_XDECREF(var); var = new;" with "Py_XSETREF(var, new);"
  • Replace "Py_CLEAR(var); var = new;" with "Py_XSETREF(var, new);"

Other changes:

  • Replace "old = var; var = new; Py_DECREF(var)" with "Py_SETREF(var, new);"
  • Replace "old = var; var = new; Py_XDECREF(var)" with "Py_XSETREF(var, new);"
  • And remove the "old" variable.

@vstinner
gh-99537: Use Py_SETREF() function in C code
11d3764 
Fix potential race condition in code patterns:

* Replace "Py_DECREF(var); var = new;" with "Py_SETREF(var, new);"
* Replace "Py_XDECREF(var); var = new;" with "Py_XSETREF(var, new);"
* Replace "Py_CLEAR(var); var = new;" with "Py_XSETREF(var, new);"

Other changes:

* Replace "old = var; var = new; Py_DECREF(var)"
  with "Py_SETREF(var, new);"
* Replace "old = var; var = new; Py_XDECREF(var)"
  with "Py_XSETREF(var, new);"
* And remove the "old" variable.
@bedevere-bot bedevere-bot mentioned this pull request Nov 21, 2022
Closed
@vstinner vstinner mentioned this pull request Nov 21, 2022
Closed
@vstinner vstinner merged commit 135ec7c into python:main Nov 22, 2022
@vstinner vstinner deleted the py_only_setref2 branch November 22, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot