Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Promote helping with reviews more #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue May 11, 2017 · 3 comments
Closed

Promote helping with reviews more #194

brettcannon opened this issue May 11, 2017 · 3 comments
Labels
hacktoberfest help wanted

Comments

@brettcannon
Copy link
Member

This might fall out as part of #189 , but as of right now all of the highly promoted activities for people to contribute by are (in order of the index):

  1. Docs
  2. Test coverage
  3. Silence warnings
  4. Fixing issues from buildbots
  5. Fixing "easy" issues
  6. Triaging issues

There is no mention of helping to review PRs. And idea 6 for helping triage issues is at the end. Unfortunately triaging issues and helping to review PRs can be the most helpful as they help reduce the workload for core devs versus ideas 1 - 5 which make work for core devs.

Now it might not entirely make sense to have people start with triage and code review, but the point should be made somehow that activities that reduce workload is really important.
@terryjreedy
Copy link
Member

One cannot edit headers right away, but one can evaluate issues and leave comments right away. 1. Is issue bug or enhancement? 2. If bug, present on current release or different OS or system?* 3. If enhancement, is it useful? Is function already present? That is how I started and would advise others to start.

  • Some issues really need testing on multiple systems, and this is something most people cannot do alone.

@brettcannon
Copy link
Member Author

@terryjreedy hopefully that's covered by https://cpython-devguide.readthedocs.io/tracker.html#helptriage (which should probably be merged with https://cpython-devguide.readthedocs.io/triaging.html with a clear separation of what anyone can do and what people with Contirbutor privileges can do).

@Mariatta
Copy link
Member

Mariatta commented Aug 29, 2017 •
edited
Loading

Maybe include the following shortcuts:

Open PRs awaiting reviews:
https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3A%22awaiting%20review%22

Open PRs awaiting core reviews:
https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3A%22awaiting%20core%20review%22%20

@mariocj89 mariocj89 mentioned this issue Oct 8, 2017
Merged
Mariatta pushed a commit that referenced this issue Oct 12, 2017
@mariocj89 @Mariatta
Suggest to the contributors to help with reviewing PRs (GH-277)
cc75ec4 
Closes #194
@Mariatta Mariatta mentioned this issue Sep 14, 2018
Closed
AA-Turner pushed a commit to AA-Turner/devguide that referenced this issue Jun 17, 2022
@mariocj89 @Mariatta
Suggest to the contributors to help with reviewing PRs (pythonGH-277)
19596aa 
Closes python#194
kitarefake added a commit to kitarefake/devguide that referenced this issue Jul 15, 2024
@kitarefake @Mariatta
Suggest to the contributors to help with reviewing PRs (GH-277)
1ee5be1 
Closes python/devguide#194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @Mariatta @terryjreedy