Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Helping with Documentation: Update old BPO info #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2023
Merged

Helping with Documentation: Update old BPO info #1025

merged 3 commits into from
Jan 10, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 9, 2023

Update redundant BPO info now we're using GitHub issues.

I'm not sure if we still need this bullet point?

-* check to see if there is a paperclip or `octocat`_ icon at the end of the
-  issue's title column.  If there is, then someone has already created a pull
+* check to see if there is pull request icon to the right of the
+  issue's title.  If there is, then someone has already created a pull
   request for the issue.

JelleZijlstra
JelleZijlstra approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bullet point is still useful; I've seen people create PRs for issues that already have one.

CAM-Gerlach
CAM-Gerlach reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to update this, though I did have a couple comments/suggestions

CAM-Gerlach
CAM-Gerlach approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

@hugovk hugovk merged commit 7ec8be4 into python:main Jan 10, 2023
@hugovk hugovk deleted the update-help-documenting branch January 10, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @JelleZijlstra @CAM-Gerlach