Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adding pullrequest guide for #103 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 12, 2017
Merged

adding pullrequest guide for #103 #140

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9e3cc06
adding pullrequest guide for #103
louisrawlins Mar 5, 2017
b62d78d
replaces GitHub, word caps
louisrawlins Mar 11, 2017
21b4960
edits - create issue
louisrawlins Mar 11, 2017
0b68c42
edits - upstream remote
louisrawlins Mar 11, 2017
523b77f
clearer create issue
louisrawlins Mar 11, 2017
e0aac2a
edits - cpython pull req
louisrawlins Mar 11, 2017
24149d3
edit - pull req
louisrawlins Mar 11, 2017
044dc08
edit - run tests, then commit
louisrawlins Mar 11, 2017
ca8e9c1
https or ssh
louisrawlins Mar 11, 2017
a3ddf1c
clarifying when to celebrate a pr
louisrawlins Mar 11, 2017
a6b773c
adding refs
louisrawlins Mar 11, 2017
ab07aef
using internal refs when available"
louisrawlins Mar 11, 2017
cebd349
swaping feature for branch
louisrawlins Mar 11, 2017
2b468f7
clarifying squishing and prs
louisrawlins Mar 11, 2017
36eb29b
alt, submit patch to bpo
louisrawlins Mar 11, 2017
1ae31e5
added ssh https ref
louisrawlins Mar 11, 2017
9865ccf
review adds to guide
louisrawlins Mar 23, 2017
2a7bb10
proper rst refs
louisrawlins Mar 24, 2017
a37d2e6
Add a missing word
Mariatta Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
swaping feature for branch
  • Loading branch information
@louisrawlins
louisrawlins committed Mar 11, 2017
commit cebd3496d1ccd1e79e56667fb802d100a420e4dd
6 changes: 3 additions & 3 deletions pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Replace **YOUR_GITHUB_ID** with your GitHub account name above, then add upstrea

Work on new features or fixes::

git checkout -b MY_NEW_FEATURE upstream/master
git checkout -b MY_BRANCH_NAME upstream/master

As you work, please create a separate commit for each bug fix or feature change::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit misleading, since each PR should either fix a bug or add a new feature.


Expand All @@ -167,9 +167,9 @@ Use rebase -i to verify what you commit and squish small commits::

Then push your work to your clone on GitHub::

git push origin MY_NEW_FEATURE
git push origin MY_BRANCH_NAME

When you're ready, make a Pull Request on GitHub and refer to your branch named **MY_NEW_FEATURE**.
When you're ready, make a Pull Request on GitHub and refer to your branch named **MY_BRANCH_NAME**.

*Though submitting a Pull Request on GitHub is the preferred method of contribution, you can alternatively upload a patch to bugs.python.org*

Expand Down